Skip to content

Add the focus glow and secondary button names from the colour list - #810

Merged
ilicfilip merged 1 commit into
developfrom
filip/ssot-focus-glow-secondary
Nov 19, 2026
Merged

ilicfilip merged 1 commit into
developfrom
filip/ssot-focus-glow-secondary

Conversation

@ilicfilip

@ilicfilip ilicfilip commented Nov 19, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Adds three names from Mijke's colour list (Figma "ssot-color-list", buttons section) to Progress Planner:

  • --prpl-color-focus-glow: the button colour at 20%, for the glow around a focused input field. Text, email, number, URL, phone and search inputs, textareas and selects in .prpl-wrap now get the button-coloured border plus a 2px glow. Before this they had WordPress's blue focus ring.
  • --prpl-color-button-secondary: the secondary button background. Mijke's value is #FFF / var(--prpl-background-paper), the same as the current background, so the button looks the same.
  • --prpl-color-button-secondary-hover: the hover background, 6% of the secondary border colour. It replaces the local --prpl-button-secondary-tint with the same value.

All three are defined in variables-color.css next to --prpl-color-button-primary-hover.

Testing

  • npm run lint:css passes, and the pre-commit token check passes (0 errors).
  • On planner.test with the Zonnet brand (7400), with a temporary test button and input added to the page:
    • The secondary button is white with the purple outline, and its hover background is the 6% purple tint.
    • A focused text input has a purple border and a 2px purple glow at 20%.
    • The console has no errors.

Goes with branding-api #20 (token list) and AI Connector #87 (same glow on its inputs), both on git.your.online.

🤖 Generated with Claude Code

https://claude.ai/code/session_0171WwmntSkVSm2F6vZeJEaQ

@github-actions

Copy link
Copy Markdown
Contributor

Plugin readme preview

Open preview · Commit d25e44b

35 passed · 0 warnings · 2 notes

Notes (2)
  • screenshot-8.png has no caption in the Screenshots section.
  • screenshot-9.png has no caption in the Screenshots section.
Passed checks (35)
  • 144 / 150 characters in the short description.
  • Plugin name header recognized.
  • License header recognized: GPL3+.
  • 4 tags accepted within the five-tag limit.
  • Description is within the parser’s word limit.
  • Installation is within the parser’s word limit.
  • Faq is within the parser’s word limit.
  • Changelog is within the parser’s word limit.
  • Tested up to 7.1, the latest WordPress major release.
  • Stable tag is declared: 1.10.1.
  • The PHP Version header is declared: 1.10.1.
  • Stable tag matches the PHP Version header: 1.10.1.
  • The readme “Requires at least” value is valid: 6.7.
  • The PHP “Requires at least” header is a numeric version: 6.7.
  • “Requires at least” matches between the readme and PHP header: 6.7.
  • The readme “Requires PHP” value is valid: 7.4.
  • The PHP “Requires PHP” header is a numeric version: 7.4.
  • “Requires PHP” matches between the readme and PHP header: 7.4.
  • “Tested up to” 7.1 meets the minimum WordPress version 6.7.
  • Installation content is present.
  • FAQ content is present.
  • Changelog content is present.
  • Screenshot captions are present.
  • The first changelog release matches Stable tag: 1.10.1.
  • The first changelog release matches PHP Version: 1.10.1.
  • Banner image loaded.
  • Plugin icon loaded.
  • Screenshot 1 has a matching image and caption.
  • Screenshot 2 has a matching image and caption.
  • Screenshot 3 has a matching image and caption.
  • Screenshot 4 has a matching image and caption.
  • Screenshot 5 has a matching image and caption.
  • Screenshot 6 has a matching image and caption.
  • Screenshot 7 has a matching image and caption.
  • Plugin PHP header loaded.

Readme and PHP-header checks only; this does not test plugin runtime compatibility.

@github-actions

github-actions Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Test merged PR on Playground
Test this pull request on the Playground
or download the zip

@github-actions

Copy link
Copy Markdown
Contributor

✅ Code Coverage Report

Metric Value
Total Coverage 35.07% 📉
Base Coverage 35.07%
Difference 📈 0.00%

⚠️ Coverage below recommended 40% threshold

🎉 Great job maintaining/improving code coverage!

ℹ️ About this report
  • All tests run in a single job with Xdebug coverage
  • Security tests excluded from coverage to prevent output issues
  • Coverage calculated from line coverage percentages

@github-actions

Copy link
Copy Markdown
Contributor

🔍 WordPress Plugin Check Report

⚠️ Status: Passed with warnings

📊 Report

🎯 Total Issues ❌ Errors ⚠️ Warnings
10 0 10

⚠️ Warnings (10)

📁 classes/suggested-tasks/data-collector/class-unpublished-content.php (1 warning)
📍 Line 🔖 Check 💬 Message
103 WordPressVIPMinimum.Performance.WPQueryParams.PostNotIn_post__not_in Using exclusionary parameters, like post__not_in, in calls to get_posts() should be done with caution, see https://docs.wpvip.com/databases/optimize-queries/using-post__not_in/ for more information.
📁 classes/suggested-tasks/providers/class-content-review.php (4 warnings)
📍 Line 🔖 Check 💬 Message
232 WordPressVIPMinimum.Performance.WPQueryParams.PostNotIn_post__not_in Using exclusionary parameters, like post__not_in, in calls to get_posts() should be done with caution, see https://docs.wpvip.com/databases/optimize-queries/using-post__not_in/ for more information.
377 WordPressVIPMinimum.Performance.WPQueryParams.PostNotIn_post__not_in Using exclusionary parameters, like post__not_in, in calls to get_posts() should be done with caution, see https://docs.wpvip.com/databases/optimize-queries/using-post__not_in/ for more information.
381 WordPressVIPMinimum.Performance.WPQueryParams.PostNotIn_post__not_in Using exclusionary parameters, like post__not_in, in calls to get_posts() should be done with caution, see https://docs.wpvip.com/databases/optimize-queries/using-post__not_in/ for more information.
388 WordPressVIPMinimum.Performance.WPQueryParams.PostNotIn_post__not_in Using exclusionary parameters, like post__not_in, in calls to get_posts() should be done with caution, see https://docs.wpvip.com/databases/optimize-queries/using-post__not_in/ for more information.
📁 classes/activities/class-query.php (2 warnings)
📍 Line 🔖 Check 💬 Message
71 PluginCheck.Security.DirectDB.UnescapedDBParameter Unescaped parameter $table_name used in $wpdb->query()\n$table_name assigned unsafely at line 58.
163 PluginCheck.Security.DirectDB.UnescapedDBParameter Unescaped parameter $where_args used in $wpdb->get_results()\n$where_args assigned unsafely at line 153.
📁 classes/suggested-tasks/data-collector/class-yoast-orphaned-content.php (1 warning)
📍 Line 🔖 Check 💬 Message
111 PluginCheck.Security.DirectDB.UnescapedDBParameter Unescaped parameter $query used in $wpdb->get_row()\n$query assigned unsafely at line 98.
📁 classes/suggested-tasks/data-collector/class-terms-without-description.php (1 warning)
📍 Line 🔖 Check 💬 Message
108 PluginCheck.Security.DirectDB.UnescapedDBParameter Unescaped parameter $query used in $wpdb->get_results()\n$query assigned unsafely at line 106.
📁 classes/suggested-tasks/data-collector/class-terms-without-posts.php (1 warning)
📍 Line 🔖 Check 💬 Message
120 PluginCheck.Security.DirectDB.UnescapedDBParameter Unescaped parameter $query used in $wpdb->get_results()\n$query assigned unsafely at line 118.

🤖 Generated by WordPress Plugin Check Action • Learn more about Plugin Check

@ilicfilip
ilicfilip merged commit b78be81 into develop Nov 19, 2026
23 checks passed
@ilicfilip
ilicfilip deleted the filip/ssot-focus-glow-secondary branch November 19, 2026 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant